Repository navigation
deps: lance 14 / lancedb 0.41 (arrow 58, datafusion 54 unchanged) - #2028
Merged
Merged
Conversation
…unchanged) lancedb 0.41.0 requires lance =14.0.2 and keeps arrow ^58, datafusion ^54, object_store ^0.14.1. Every lance-family pin floats on the 14 line; pin notes in CLAUDE.md and the crepe-plan-probe comment follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
Pre-merge checks:
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
AdaWorldAPI
marked this pull request as ready for review
November 11, 2026 22:44
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…row_id_prefilter lance 14 deprecates the old name as a plain alias of with_row_id_prefilter (same RowAddrMask, same _rowid domain), so the rename keeps behaviour and clears the -D warnings failure in the crepe-plan-probe job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the lance family to lance 14 / lancedb 0.41. lancedb 0.41.0 requires
lance =14.0.2; arrow stays at^58, datafusion at^54, object_store at^0.14.1. Following the pin rule in CLAUDE.md, every lance-family pin floats the patch (14.*,0.41.*). No Cargo.lock is tracked.Changed: the root
Cargo.tomlworkspace table, pluslance-graph,lance-graph-catalog,holograph,lance-graph-dir-sim-lance,crepe-plan-probe,holo-lance-masked-io-probeandholo-h14d-probe. The CLAUDE.md pin notes now record the 14 line.Evidence
cargo check --workspace --all-targetspasses. It resolves lance 14.0.2, arrow-array 58.4.1 and datafusion 54.1.0.cargo check:lance-graph-dir-sim-lance,crepe-plan-probe(lancedb 0.41 withremote),holo-lance-masked-io-probe,holo-h14d-probe.holograph's lib compiles with--features lancedb.lance-graph-catalogtests: 12 + 17 + 1 pass.lance-graph --lib --testscould not finish locally: the sandbox ran out of disk during linking (ld ... Bus error). CI covers it:test,test-with-coverage,member-testsandclippyare all green.Scanner::with_row_addr_prefilteras a plain alias ofwith_row_id_prefilter(sameRowAddrMask, same_rowiddomain). The second commit renames all call sites. That fixed the-D warningsfailure in the crepe-plan-probe job. Localcargo clippy --all-targets -- -D warningson that crate passes too.Not changed
LanceTableProvider, which this repo does not use. This bump does not turn it on anywhere.holographtests fail to build with E0596 atsrc/mindmap.rs:869(mindmap.bfsneedslet mut). The same failure happens with or without features on main, so it predates this bump and is left alone here.https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
Generated by Claude Code